]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ext4: fix potential race between s_flex_groups online resizing and access
authorSuraj Jitindar Singh <surajjs@amazon.com>
Wed, 19 Feb 2020 03:08:51 +0000 (19:08 -0800)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 5 Mar 2020 09:37:10 +0000 (10:37 +0100)
commitd02c82c5cdec78dcbec0f01dcbd1d12a9f182363
tree330cf0757667fd29ac2895377921fd51c793f1b1
parent9bee93bfa7753336e1b1c1ede7e86227ef3242f1
ext4: fix potential race between s_flex_groups online resizing and access

BugLink: https://bugs.launchpad.net/bugs/1866165
commit 7c990728b99ed6fbe9c75fc202fce1172d9916da upstream.

During an online resize an array of s_flex_groups structures gets replaced
so it can get enlarged. If there is a concurrent access to the array and
this memory has been reused then this can lead to an invalid memory access.

The s_flex_group array has been converted into an array of pointers rather
than an array of structures. This is to ensure that the information
contained in the structures cannot get out of sync during a resize due to
an accessor updating the value in the old structure after it has been
copied but before the array pointer is updated. Since the structures them-
selves are no longer copied but only the pointers to them this case is
mitigated.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=206443
Link: https://lore.kernel.org/r/20200221053458.730016-4-tytso@mit.edu
Signed-off-by: Suraj Jitindar Singh <surajjs@amazon.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/ext4/ext4.h
fs/ext4/ialloc.c
fs/ext4/mballoc.c
fs/ext4/resize.c
fs/ext4/super.c