]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
bpf: fix a (false) compiler warning
authorPeter Oskolkov <posk@google.com>
Wed, 16 Jan 2019 18:43:01 +0000 (10:43 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 17 Jan 2019 09:40:16 +0000 (10:40 +0100)
commitd0b2818efbe27e6c2e0c52621c8db18eb5abb5e1
tree5c56548f2657341295bbe2fd9a02fe4ff96c29c6
parent4edc01b846b765fed615ce84cc204453bd983dbf
bpf: fix a (false) compiler warning

An older GCC compiler complains:

kernel/bpf/verifier.c: In function 'bpf_check':
kernel/bpf/verifier.c:4***:13: error: 'prev_offset' may be used uninitialized
      in this function [-Werror=maybe-uninitialized]
   } else if (krecord[i].insn_offset <= prev_offset) {
             ^
kernel/bpf/verifier.c:4***:38: note: 'prev_offset' was declared here
  u32 i, nfuncs, urec_size, min_size, prev_offset;

Although the compiler is wrong here, the patch makes sure
that prev_offset is always initialized, just to silence the warning.

v2: fix a spelling error in the commit message.

Signed-off-by: Peter Oskolkov <posk@google.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/verifier.c