]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
sctp: update order of adjustments of partial_bytes_acked and cwnd
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Fri, 23 Jun 2017 22:59:33 +0000 (19:59 -0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Jun 2017 18:43:53 +0000 (14:43 -0400)
commitd0b53f40977446fdf2460b14d4544d1375a3138d
tree410a4d86328858a353481cc860916648d3aa7a4a
parentf3ecab38240b624b37e003b5089a93682b109699
sctp: update order of adjustments of partial_bytes_acked and cwnd

RFC4960 Errata 3.12 says RFC4960 is unclear about the order of
adjustments applied to partial_bytes_acked and cwnd in the congestion
avoidance phase, and that the actual order should be:
partial_bytes_acked is reset to (partial_bytes_acked - cwnd). Next, cwnd
is increased by MTU.

We were first increasing cwnd, and then subtracting the new value pba,
which leads to a different result as pba is smaller than what it should
and could cause cwnd to not grow as much.

See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-rfc4960-errata-01#section-3.12
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/transport.c