]> git.proxmox.com Git - libgit2.git/commit
Fix uninitialized variable warning
authorMatthew Plough <matt@arena.io>
Fri, 27 Jan 2017 17:49:48 +0000 (12:49 -0500)
committerMatthew Plough <matt@arena.io>
Fri, 27 Jan 2017 17:49:48 +0000 (12:49 -0500)
commitd0c418c0bb150cce670bbfd1d9343f91f894125a
tree2b547ee22de2835a904a0980008a86057845ca45
parent8df1cfc9d710db48469e2ea34152cfe03d4bf515
Fix uninitialized variable warning

Fix the following warning emitted by clang:
[ 16%] Building C object CMakeFiles/libgit2_clar.dir/src/submodule.c.o
/Users/mplough/devel/external/libgit2/src/submodule.c:408:6: warning: variable 'i' is used uninitialized whenever 'if' condition is true
      [-Wsometimes-uninitialized]
        if ((error = load_submodule_names(names, cfg)))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mplough/devel/external/libgit2/src/submodule.c:448:20: note: uninitialized use occurs here
        git_iterator_free(i);
                          ^
/Users/mplough/devel/external/libgit2/src/submodule.c:408:2: note: remove the 'if' if its condition is always false
        if ((error = load_submodule_names(names, cfg)))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mplough/devel/external/libgit2/src/submodule.c:404:17: note: initialize the variable 'i' to silence this warning
        git_iterator *i;
                       ^
                        = NULL
1 warning generated.
src/submodule.c