]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/i915: Avoid spurious WARNs about the wrong pipe in the PPS code
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 8 Feb 2017 17:52:54 +0000 (19:52 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 10 Feb 2017 16:44:18 +0000 (18:44 +0200)
commitd158694f452252d0fef335a775aeb3eb74fe7af0
treeee3b208e3bf6079f093e3dcaff09a39d32d058ae
parent51a831a7725b1273381cb4a9f3f0d619276e3521
drm/i915: Avoid spurious WARNs about the wrong pipe in the PPS code

Until recently vlv_steal_power_sequencer() wasn't being called for
normal DP ports, and hence it could assert that it should only be
called for pipe A and B (since pipe C doesn't support eDP). However
that changed when we started to consider normal DP ports as well when
choosing a PPS. So we will now get spurious warnings when
vlv_steal_power_sequencer() does get called for pipe C. Avoid this by
moving the WARN down into vlv_detach_power_sequencer() where this
assertion should still hold.

Cc: Imre Deak <imre.deak@intel.com>
Cc: stable@vger.kernel.org
Fixes: 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV")
References: https://bugs.freedesktop.org/show_bug.cgi?id=95287
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170208175254.10958-1-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/intel_dp.c