]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
nfsd: fix performance-limiting session calculation
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 21 Feb 2019 15:47:00 +0000 (10:47 -0500)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 25 Mar 2019 15:47:47 +0000 (10:47 -0500)
commitd182be48630749cc4ec930a82aa62eb44c51de31
tree5a3e6eb3b33101ce71a823d2725fb5acaaf916ad
parent264f36b154999b7635e66efbd3c0589709dcedb7
nfsd: fix performance-limiting session calculation

BugLink: https://bugs.launchpad.net/bugs/1821607
commit c54f24e338ed2a35218f117a4a1afb5f9e2b4e64 upstream.

We're unintentionally limiting the number of slots per nfsv4.1 session
to 10.  Often more than 10 simultaneous RPCs are needed for the best
performance.

This calculation was meant to prevent any one client from using up more
than a third of the limit we set for total memory use across all clients
and sessions.  Instead, it's limiting the client to a third of the
maximum for a single session.

Fix this.

Reported-by: Chris Tracy <ctracy@engr.scu.edu>
Cc: stable@vger.kernel.org
Fixes: de766e570413 "nfsd: give out fewer session slots as limit approaches"
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
fs/nfsd/nfs4state.c