]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
pwm: Set enable state properly on failed call to enable
authorJonathan Richardson <jonathar@broadcom.com>
Sat, 17 Oct 2015 00:40:58 +0000 (17:40 -0700)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 10 Nov 2015 12:06:16 +0000 (13:06 +0100)
commitd1cd21427747f15920cd726f5f67a07880e7dee4
tree429e8844a75def440f47479f751e60f9ff685f0c
parentf080be27d7d9333e4815655a2cedab91c3aa7acc
pwm: Set enable state properly on failed call to enable

The pwm_enable() function didn't clear the enabled bit if a call to the
driver's ->enable() callback returned an error. The result was that the
state of the PWM core was wrong. Clearing the bit when enable returns
an error ensures the state is properly set.

Tested-by: Jonathan Richardson <jonathar@broadcom.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
[thierry.reding@gmail.com: add missing kerneldoc for the lock]
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/core.c
include/linux/pwm.h