]> git.proxmox.com Git - ovs.git/commit
datapath-windows: Fix bug in OvsTcpGetWscale().
authorDaniele Di Proietto <diproiettod@vmware.com>
Sat, 16 Apr 2016 00:04:53 +0000 (17:04 -0700)
committerDaniele Di Proietto <diproiettod@vmware.com>
Wed, 27 Apr 2016 07:01:38 +0000 (00:01 -0700)
commitd291a10c50434707405d8cd1437ec62e10c43bb5
tree63205db59c033e815ad6456116c5c1df96a92805
parent4ec3d7c7578e827a543cc0989a6cd4c1a10ee291
datapath-windows: Fix bug in OvsTcpGetWscale().

The userspace conntrack had a bug in tcp_wscale_get(), where the length
of an option would be read from the third octet of the option TLV
instead of the second.  This could cause an incorrect wscale value to
be returned, and it would at least impact performance.

Also use 'int' instead of 'unsigned' for 'len', since the value can be
negative.

CC: Sairam Venugopal <vsairam@vmware.com>
Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
datapath-windows/ovsext/Conntrack-tcp.c