]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
UBUNTU: SAUCE: nvme: Don't suspend admin queue that wasn't created
authorGabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Tue, 13 Sep 2016 13:39:06 +0000 (07:39 -0600)
committerKamal Mostafa <kamal@canonical.com>
Mon, 19 Sep 2016 14:40:27 +0000 (07:40 -0700)
commitd2b59eefb500ce0facde7711c9ad7e2201162daa
treee9546da8ab55c2cd6e435556832ee8798fbd7006
parentf463371e13cf8ac8ea79368639f4b6a61258f139
UBUNTU: SAUCE: nvme: Don't suspend admin queue that wasn't created

Pending 4.8-rc merge.
BugLink: http://bugs.launchpad.net/bugs/1602724
This fixes a regression in my previous commit c21377f8366c ("nvme:
Suspend all queues before deletion"), which provoked an Oops in the
removal path when removing a device that became IO incapable very early
at probe (i.e. after a failed EEH recovery).

Turns out, if the error occurred very early at the probe path, before
even configuring the admin queue, we might try to suspend the
uninitialized admin queue, accessing bad memory.

Fixes: c21377f8366c ("nvme: Suspend all queues before deletion")
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Brad Figg <brad.figg@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
drivers/nvme/host/pci.c