]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
ALSA: hda - Keep powering up ADCs on Cirrus codecs
authorTakashi Iwai <tiwai@suse.de>
Tue, 19 Apr 2016 20:07:50 +0000 (22:07 +0200)
committerKamal Mostafa <kamal@canonical.com>
Mon, 16 May 2016 17:25:32 +0000 (10:25 -0700)
commitd2c1de20bb3f02aa1a4cafbccbacf8899f62d565
tree8a872826196431e336ccc87c2db836827c825c5c
parentb343258a0ca8222112e8b1ec78c346fe718d2c06
ALSA: hda - Keep powering up ADCs on Cirrus codecs

BugLink: http://bugs.launchpad.net/bugs/1578798
commit de3df8a986b635082a1d94bae2c361d043c57106 upstream.

Although one weird behavior about the input path (inconsistent D0/D3
switch) on Cirrus CS420x codecs was fixed in the previous commit,
there is still an issue on some Mac machines: the capture stream
stalls when switching the ADCs on the fly.  More badly, this keeps
stuck until the next reboot.

The dynamic ADC switching is already a bit fragile and assuming
optimistically that the chip accepts the frequent power changes.  On
Cirrus codecs, this doesn't seem applicable.

As a quick workaround, we pin down the ADCs to keep up in D0 when
spec->dyn_adc_switch is set.  In this way, the ADCs are kept up only
for the system that were confirmed to be broken.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116171
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
sound/pci/hda/patch_cirrus.c