]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ASoC: rt715-sdca-sdw: use first_hw_init flag on resume
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 7 Jun 2021 22:22:33 +0000 (17:22 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 8 Jun 2021 12:36:35 +0000 (13:36 +0100)
commitd34d0897a753f42c8a7a6af3866781dd57344a45
tree34f2a0cc0144a59223f970b90bd6c0ef119679b8
parenta0897ebca669f09a2e02206a9c48a738af655329
ASoC: rt715-sdca-sdw: use first_hw_init flag on resume

The intent of the status check on resume was to verify if a SoundWire
peripheral reported ATTACHED before waiting for the initialization to
complete. This is required to avoid timeouts that will happen with
'ghost' devices that are exposed in the platform firmware but are not
populated in hardware.

Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to
another error, the resume operation never timed out, but the volume
settings were not properly restored.

This patch renames the status flag to 'first_hw_init' for consistency
with other drivers (was 'first_init')

BugLink: https://github.com/thesofproject/linux/issues/2908
BugLink: https://github.com/thesofproject/linux/issues/2637
Fixes: 20d17057f0a8c ('ASoC: rt715-sdca: Add RT715 sdca vendor-specific driver')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
Link: https://lore.kernel.org/r/20210607222239.582139-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt715-sdca-sdw.c
sound/soc/codecs/rt715-sdca.c
sound/soc/codecs/rt715-sdca.h