]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sgi-gru: decrapfiy options_write() function
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Nov 2009 18:48:30 +0000 (10:48 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Nov 2009 18:48:30 +0000 (10:48 -0800)
commitd39b7dd1dcbf394a1cb897457c862dafe9a20ac5
tree2eebf445f1b61cf09abd62d5a2dc4a314f0d6803
parent91d3f9bacdb4950d2f79fe2ba296aa249f60d06c
sgi-gru: decrapfiy options_write() function

Not a single line of actual code in the function was really
fundamentally correct.

Problems ranged from lack of proper range checking, to removing the last
character written (which admittedly is usually '\n'), to not accepting
hex numbers even though the 'show' routine would show the data in that
format.

This tries to do better.

Acked-by: Michael Buesch <mb@bu3sch.de>
Tested-and-acked-by: Jack Steiner <steiner@sgi.com>
Cc: stable@kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Michael Gilbert <michael.s.gilbert@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/misc/sgi-gru/gruprocfs.c