]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
selftests/bpf: Fix check_mtu using wrong variable type
authorJesper Dangaard Brouer <brouer@redhat.com>
Tue, 6 Jun 2023 11:30:47 +0000 (13:30 +0200)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:19:35 +0000 (17:19 +0200)
commitd3b3181588d210956da576e68f333618814f0d85
tree9fb754399971bd0c7b42599c35fecf0efdb828bf
parent8cfb5085c00d85932054ef6f7759fea990685a7a
selftests/bpf: Fix check_mtu using wrong variable type

BugLink: https://bugs.launchpad.net/bugs/2034469
[ Upstream commit 095641817e1bf6aa2560e025e47575188ee3edaf ]

Dan Carpenter found via Smatch static checker, that unsigned 'mtu_lo' is
never less than zero.

Variable mtu_lo should have been an 'int', because read_mtu_device_lo()
uses minus as error indications.

Fixes: b62eba563229 ("selftests/bpf: Tests using bpf_check_mtu BPF-helper")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/bpf/168605104733.3636467.17945947801753092590.stgit@firesoul
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/testing/selftests/bpf/prog_tests/check_mtu.c