]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
scsi: mpt3sas: Fix NULL pointer access in mpt3sas_transport_port_add()
authorWenchao Hao <haowenchao2@huawei.com>
Sat, 25 Feb 2023 10:01:36 +0000 (18:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 8 Mar 2023 02:02:09 +0000 (21:02 -0500)
commitd3c57724f1569311e4b81e98fad0931028b9bdcd
tree3ead6c2142e79c2ddd58b1627d3b6f5289d511a2
parent288b3271d920c9ba949c3bab0f749f4cecc70e09
scsi: mpt3sas: Fix NULL pointer access in mpt3sas_transport_port_add()

Port is allocated by sas_port_alloc_num() and rphy is allocated by either
sas_end_device_alloc() or sas_expander_alloc(), all of which may return
NULL. So we need to check the rphy to avoid possible NULL pointer access.

If sas_rphy_add() returned with failure, rphy is set to NULL. We would
access the rphy in the following lines which would also result NULL pointer
access.

Fixes: 78316e9dfc24 ("scsi: mpt3sas: Fix possible resource leaks in mpt3sas_transport_port_add()")
Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
Link: https://lore.kernel.org/r/20230225100135.2109330-1-haowenchao2@huawei.com
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_transport.c