]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
arm64: topology: fix possible overflow in amu_fie_setup()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Fri, 16 Sep 2022 20:17:07 +0000 (23:17 +0300)
committerWill Deacon <will@kernel.org>
Thu, 22 Sep 2022 11:57:06 +0000 (12:57 +0100)
commitd4955c0ad77dbc684fc716387070ac24801b8bca
tree9311ec80e3e76ab5f92e1ce2f8c1f5da9398f1bc
parent61d2d1808b20da4a45a90b4bd61ae92f729bab78
arm64: topology: fix possible overflow in amu_fie_setup()

cpufreq_get_hw_max_freq() returns max frequency in kHz as *unsigned int*,
while freq_inv_set_max_ratio() gets passed this frequency in Hz as 'u64'.
Multiplying max frequency by 1000 can potentially result in overflow --
multiplying by 1000ULL instead should avoid that...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: cd0ed03a8903 ("arm64: use activity monitors for frequency invariance")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/01493d64-2bce-d968-86dc-11a122a9c07d@omp.ru
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/topology.c