]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
usb: webcam: Invalid size of Processing Unit Descriptor
authorPawel Laszczak <pawell@cadence.com>
Mon, 15 Mar 2021 07:17:48 +0000 (08:17 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:31:58 +0000 (10:31 +0200)
commitd4a2380aa597cd8a3e60da988990b647ae1c044c
tree0c6f5229b84348a3b8b327fcd04a07bd7b63d6db
parent2aa4adc804ef0ecb430a872644214b3157896472
usb: webcam: Invalid size of Processing Unit Descriptor

BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit 6a154ec9ef6762c774cd2b50215c7a8f0f08a862 ]

According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.

Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds bmVideoStandards into
uvc_processing_unit_descriptor structure.

The bmVideoStandards field was added in UVC 1.1 and it wasn't part of
UVC 1.0a.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Peter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/20210315071748.29706-1-pawell@gli-login.cadence.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/usb/gadget/function/f_uvc.c
drivers/usb/gadget/legacy/webcam.c
include/uapi/linux/usb/video.h