]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
gianfar: Call netif_carrier_off() prior to registration
authorFabio Estevam <fabio.estevam@freescale.com>
Tue, 3 Jun 2014 22:55:38 +0000 (19:55 -0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jun 2014 22:03:46 +0000 (15:03 -0700)
commitd4c642ea1239f0c5c1d794a5b788319d3373c58c
treefefa5990e0a8cdfa5ce21b997297805fc6b68592
parent3bfdc59a6c24608ed23e903f670aaf5f58c7a6f3
gianfar: Call netif_carrier_off() prior to registration

Quoting David Miller:
"At the moment you call register_netdev() the device is visible, notifications
are sent to userspace, and userland tools can try to bring the interface up
and see the incorrect link state, before you do the netif_carrier_off().

Said another way, between the register_netdev() and netif_carrier_off() call,
userspace can see the device in an inconsistent state."

So call netif_carrier_off() prior to register_netdev().

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c