]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
PCI: keystone: Fix interrupt-controller-node lookup
authorJohan Hovold <johan@kernel.org>
Fri, 17 Nov 2017 13:38:31 +0000 (14:38 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Fri, 23 Feb 2018 14:27:24 +0000 (08:27 -0600)
commitd4d1f39cbfb08e2da6bed4d24106b5ea13dd0926
tree0b06e6748c40ab8ab63505a6b0eb7ea9699fd4b1
parentd9e0ee27b029d6fa586db036931e419344990062
PCI: keystone: Fix interrupt-controller-node lookup

BugLink: http://bugs.launchpad.net/bugs/1751131
commit eac56aa3bc8af3d9b9850345d0f2da9d83529134 upstream.

Fix child-node lookup during initialisation which was using the wrong
OF-helper and ended up searching the whole device tree depth-first
starting at the parent rather than just matching on its children.

To make things worse, the parent pci node could end up being prematurely
freed as of_find_node_by_name() drops a reference to its first argument.
Any matching child interrupt-controller node was also leaked.

Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
Cc: stable <stable@vger.kernel.org> # 3.18
Acked-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
[lorenzo.pieralisi@arm.com: updated commit subject]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/pci/dwc/pci-keystone.c