]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
usbip: Fix free of unallocated memory in vhci tx
authorSuwan Kim <suwan.kim027@gmail.com>
Tue, 22 Oct 2019 09:30:17 +0000 (18:30 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Oct 2019 16:51:06 +0000 (17:51 +0100)
commitd4d8257754c3300ea2a465dadf8d2b02c713c920
treefef21ca998d53333180ec2e9ad1032c87f7fe3e1
parent28df0642abbf6d66908a2858922a7e4b21cdd8c2
usbip: Fix free of unallocated memory in vhci tx

iso_buffer should be set to NULL after use and free in the while loop.
In the case of isochronous URB in the while loop, iso_buffer is
allocated and after sending it to server, buffer is deallocated. And
then, if the next URB in the while loop is not a isochronous pipe,
iso_buffer still holds the previously deallocated buffer address and
kfree tries to free wrong buffer address.

Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
Reviewed-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20191022093017.8027-1-suwan.kim027@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/vhci_tx.c