]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm: rcar-du: add missing of_node_put
authorJulia Lawall <julia.lawall@lip6.fr>
Mon, 14 Jan 2019 16:44:56 +0000 (17:44 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitd505f2294297e4e84dae1f48bda257abfd33d6e6
tree83cb327bfe82b0949c0327051ac21241bb8bf5ae
parentb8f23d308c9d6f9e3b3a41ee72e119156aeb5240
drm: rcar-du: add missing of_node_put

BugLink: https://bugs.launchpad.net/bugs/1838116
[ Upstream commit 4c6d8fc20b09f9684743afd72e4dbc3f15524479 ]

Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.

Add a second of_node_put if no encoder is selected (encoder remains NULL).

The semantic match that finds the first problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
    when != true e == NULL
    when != of_node_put(e)
    when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/rcar-du/rcar_du_kms.c