]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()
authorJarkko Sakkinen <jarkko@kernel.org>
Fri, 19 Feb 2021 22:55:59 +0000 (00:55 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Apr 2021 16:31:48 +0000 (18:31 +0200)
commitd52c48228c518c4e22362d8d9b5b54086b9ef6a9
tree7785489f70af301854740418ade225793757cb35
parentfca5581fa29dbdf3ff98b2ec368a70bf30f8f0a2
tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()

BugLink: https://bugs.launchpad.net/bugs/1920238
commit a5665ec2affdba21bff3b0d4d3aed83b3951e8ff upstream.

This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
(SLB 9670):

[    4.324298] TPM returned invalid status
[    4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f

Background
==========

TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
Interface Locality Usage per Register, Table 39 Register Behavior Based on
Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
0xFF in case of lack of locality.

The fix
=======

Decorate tpm_get_timeouts() with request_locality() and release_locality().

Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Laurent Bigonville <bigon@debian.org>
Cc: stable@vger.kernel.org
Reported-by: Lukasz Majczak <lma@semihalf.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/char/tpm/tpm_tis_core.c