]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
clk: bcm2835: Do not use prediv with bcm2711's PLLs
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Thu, 30 Jul 2020 18:26:19 +0000 (20:26 +0200)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 4 Sep 2020 19:30:08 +0000 (16:30 -0300)
commitd563c890524efc96e2ebf338414b4da30e229fc6
tree16ca3b805f7db8af9d1c3a59c5a602792618d5a2
parent91d908af92c648604e3d3f0a71d79f2cbbd63add
clk: bcm2835: Do not use prediv with bcm2711's PLLs

BugLink: https://bugs.launchpad.net/bugs/1892899
[ Upstream commit f34e4651ce66a754f41203284acf09b28b9dd955 ]

Contrary to previous SoCs, bcm2711 doesn't have a prescaler in the PLL
feedback loop. Bypass it by zeroing fb_prediv_mask when running on
bcm2711.

Note that, since the prediv configuration bits were re-purposed, this
was triggering miscalculations on all clocks hanging from the VPU clock,
notably the aux UART, making its output unintelligible.

Fixes: 42de9ad400af ("clk: bcm2835: Add BCM2711_CLOCK_EMMC2 support")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20200730182619.23246-1-nsaenzjulienne@suse.de
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/clk/bcm/clk-bcm2835.c