]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
vxlan: fix default fdb entry netlink notify ordering during netdev create
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Fri, 20 Jul 2018 20:21:04 +0000 (13:21 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:23 +0000 (14:20 +0100)
commitd56a65688ab7220198421d8e3b84e23497675151
treee2d9705d2850c53c7f37f84c2498feb7f55c1e30
parentd7e686dc052a41fc362420a7ebba6892cb66237b
vxlan: fix default fdb entry netlink notify ordering during netdev create

BugLink: http://bugs.launchpad.net/bugs/1814813
[ Upstream commit e99465b952861533d9ba748fdbecc96d9a36da3e ]

Problem:
In vxlan_newlink, a default fdb entry is added before register_netdev.
The default fdb creation function also notifies user-space of the
fdb entry on the vxlan device which user-space does not know about yet.
(RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).

This patch fixes the user-space netlink notification ordering issue
with the following changes:
- decouple fdb notify from fdb create.
- Move fdb notify after register_netdev.
- Call rtnl_configure_link in vxlan newlink handler to notify
userspace about the newlink before fdb notify and
hence avoiding the user-space race.

Fixes: afbd8bae9c79 ("vxlan: add implicit fdb entry for default destination")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/vxlan.c