]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
coredump: cleanup "ispipe" code
authorOleg Nesterov <oleg@redhat.com>
Wed, 26 May 2010 21:43:06 +0000 (14:43 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 May 2010 16:12:45 +0000 (09:12 -0700)
commitd5bf4c4f5f9dcc90b7e25dbb2f7c4436cf6e7ed0
tree8c07402f685245fdf3397fac47bc7194f686066d
parentc713541125002b8bc9e681af3b09118e771e2d8a
coredump: cleanup "ispipe" code

- kill "int dump_count", argv_split(argcp) accepts argcp == NULL.

- move "int dump_count" under " if (ispipe)" branch, fail_dropcount
  can check ispipe.

- move "char **helper_argv" as well, change the code to do argv_free()
  right after call_usermodehelper_fns().

- If call_usermodehelper_fns() fails goto close_fail label instead
  of closing the file by hand.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/exec.c