]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
USB: legousbtower: fix open after failed reset request
authorJohan Hovold <johan@kernel.org>
Thu, 19 Sep 2019 08:30:39 +0000 (10:30 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 23 Oct 2019 13:04:25 +0000 (15:04 +0200)
commitd5f8dec11794721b6d9c551da1e07d71895a4465
treee351e16443332f2643f4afec0d1ff1a55114fce2
parent9532324bad07bef7dd608b579c4c5295cdaaf7ed
USB: legousbtower: fix open after failed reset request

BugLink: https://bugs.launchpad.net/bugs/1848750
commit 0b074f6986751361ff442bc1127c1648567aa8d6 upstream.

The driver would return with a nonzero open count in case the reset
control request failed. This would prevent any further attempts to open
the char dev until the device was disconnected.

Fix this by incrementing the open count only on successful open.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190919083039.30898-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/usb/misc/legousbtower.c