]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
minixfs: misplaced checks lead to dentry leak
authorAl Viro <viro@ZenIV.linux.org.uk>
Wed, 4 Jan 2012 10:51:03 +0000 (10:51 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jan 2012 23:03:06 +0000 (15:03 -0800)
commitd6042eac44b54dc5c7cb839175eb51dfd03d7633
treeb2a1c5878771f4d7a5aada868bdbc7eafc4eba3b
parent8a88951b5878dc475dcd841cefc767e36397d14e
minixfs: misplaced checks lead to dentry leak

bitmap size sanity checks should be done *before* allocating ->s_root;
there their cleanup on failure would be correct.  As it is, we do iput()
on root inode, but leak the root dentry...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Josh Boyer <jwboyer@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/minix/inode.c