]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
tcp: incoming connections might use wrong route under synflood
authorDmitry Popov <dp@highloadlab.com>
Thu, 11 Apr 2013 08:55:07 +0000 (08:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Apr 2013 20:01:46 +0000 (16:01 -0400)
commitd66954a066158781ccf9c13c91d0316970fe57b6
tree72a493b500858f3ea89949e21a7d9997d90d1838
parentfe2971a01762963c62e9872bfcf0632546342c0f
tcp: incoming connections might use wrong route under synflood

There is a bug in cookie_v4_check (net/ipv4/syncookies.c):
flowi4_init_output(&fl4, 0, sk->sk_mark, RT_CONN_FLAGS(sk),
   RT_SCOPE_UNIVERSE, IPPROTO_TCP,
   inet_sk_flowi_flags(sk),
   (opt && opt->srr) ? opt->faddr : ireq->rmt_addr,
   ireq->loc_addr, th->source, th->dest);

Here we do not respect sk->sk_bound_dev_if, therefore wrong dst_entry may be
taken. This dst_entry is used by new socket (get_cookie_sock ->
tcp_v4_syn_recv_sock), so its packets may take the wrong path.

Signed-off-by: Dmitry Popov <dp@highloadlab.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/syncookies.c