]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
[S390] arch/s390/kernel: Add missing unlock
authorJulia Lawall <julia@diku.dk>
Fri, 9 Apr 2010 11:42:58 +0000 (13:42 +0200)
committerMartin Schwidefsky <sky@mschwide.boeblingen.de.ibm.com>
Fri, 9 Apr 2010 11:43:01 +0000 (13:43 +0200)
commitd7015c120e0ac55d86cabbe7a14997b99f39e282
tree4b7dba31afe720577fb32efa37e1b07942de2c91
parentd620a7cf05d4f12f5bbb1060d766e8139ab31458
[S390] arch/s390/kernel: Add missing unlock

In the default case the lock is not unlocked.  The return is
converted to a goto, to share the unlock at the end of the function.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* spin_lock_irq (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/kernel/topology.c