]> git.proxmox.com Git - mirror_qemu.git/commit
migration: disallow change capabilities in COLO state
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Fri, 28 Apr 2023 19:49:27 +0000 (22:49 +0300)
committerJuan Quintela <quintela@redhat.com>
Wed, 10 May 2023 16:48:12 +0000 (18:48 +0200)
commitd70178a88fe8d0873508f6d4757018092262e9ec
tree33cbe3365210446138e84174415cbde3b4eb8438
parentecbfec6d7769b5362feac92404d564622198bf85
migration: disallow change capabilities in COLO state

COLO is not listed as running state in migrate_is_running(), so, it's
theoretically possible to disable colo capability in COLO state and the
unexpected error in migration_iteration_finish() is reachable.

Let's disallow that in qmp_migrate_set_capabilities. Than the error
becomes absolutely unreachable: we can get into COLO state only with
enabled capability and can't disable it while we are in COLO state. So
substitute the error by simple assertion.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20230428194928.1426370-10-vsementsov@yandex-team.ru>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c
migration/options.c