]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tcp: reset sk_rx_dst in tcp_disconnect()
authorWANG Cong <xiyou.wangcong@gmail.com>
Sun, 25 Jun 2017 06:50:30 +0000 (23:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Jun 2017 16:23:07 +0000 (12:23 -0400)
commitd747a7a51b00984127a88113cdbbc26f91e9d815
treeaef4eb636d2b95553a7907ae986a3b96e195bdd9
parent85cb73ff9b74785a7fc752875d7f0fe17ca3ea7c
tcp: reset sk_rx_dst in tcp_disconnect()

We have to reset the sk->sk_rx_dst when we disconnect a TCP
connection, because otherwise when we re-connect it this
dst reference is simply overridden in tcp_finish_connect().

This fixes a dst leak which leads to a loopback dev refcnt
leak. It is a long-standing bug, Kevin reported a very similar
(if not same) bug before. Thanks to Andrei for providing such
a reliable reproducer which greatly narrows down the problem.

Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.")
Reported-by: Andrei Vagin <avagin@gmail.com>
Reported-by: Kevin Xu <kaiwen.xu@hulu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c