]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
brcmfmac: use local iftype avoiding use-after-free of virtual interface
authorArend Van Spriel <arend.vanspriel@broadcom.com>
Tue, 28 Mar 2017 08:11:30 +0000 (09:11 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 30 Mar 2017 16:43:51 +0000 (19:43 +0300)
commitd77facb88448cdeaaa3adba5b9704a48ac2ac8d6
tree52a9ee41042d543f0dd0a420f8d4912ea6e41863
parent893dc68f1b18451e6d550b1884fc6be76e1bb90c
brcmfmac: use local iftype avoiding use-after-free of virtual interface

A use-after-free was found using KASAN. In brcmf_p2p_del_if() the virtual
interface is removed using call to brcmf_remove_interface(). After that
the virtual interface instance has been freed and should not be referenced.
Solve this by storing the nl80211 iftype in local variable, which is used
in a couple of places anyway.

Cc: stable@vger.kernel.org # 4.10.x, 4.9.x
Reported-by: Daniel J Blueman <daniel@quora.org>
Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c