]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: fec: restore handling of PHY reset line as optional
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Feb 2023 21:53:19 +0000 (13:53 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Feb 2023 05:12:22 +0000 (21:12 -0800)
commitd7b5e5dd669436328dbf41d89af09b3fa5de3b95
tree8a6a65a616ea1ee044b3838833ff6760e3980e24
parent82b4a9412b4de2f68679f1403f1d229390ace27e
net: fec: restore handling of PHY reset line as optional

Conversion of the driver to gpiod API done in 468ba54bd616 ("fec:
convert to gpio descriptor") incorrectly made reset line mandatory and
resulted in aborting driver probe in cases where reset line was not
specified (note: this way of specifying PHY reset line is actually
deprecated).

Switch to using devm_gpiod_get_optional() and skip manipulating reset
line if it can not be located.

Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230201215320.528319-1-dmitry.torokhov@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c