]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
hwmon: (max31790) Report correct current pwm duty cycles
authorGuenter Roeck <linux@roeck-us.net>
Wed, 26 May 2021 15:40:17 +0000 (08:40 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:45:09 +0000 (09:45 +0200)
commitd7cbda5b05b818a412eb2075f8cb21d4f4e2f18a
treeb12e35d2df1994f9e65b93eb3d6161acfacd3e27
parent69a4cb7d87ba7485d4ee722dbfe9a518f04deff0
hwmon: (max31790) Report correct current pwm duty cycles

BugLink: https://bugs.launchpad.net/bugs/1938199
[ Upstream commit 897f6339893b741a5d68ae8e2475df65946041c2 ]

The MAX31790 has two sets of registers for pwm duty cycles, one to request
a duty cycle and one to read the actual current duty cycle. Both do not
have to be the same.

When reporting the pwm duty cycle to the user, the actual pwm duty cycle
from pwm duty cycle registers needs to be reported. When setting it, the
pwm target duty cycle needs to be written. Since we don't know the actual
pwm duty cycle after a target pwm duty cycle has been written, set the
valid flag to false to indicate that actual pwm duty cycle should be read
from the chip instead of using cached values.

Cc: Jan Kundrát <jan.kundrat@cesnet.cz>
Cc: Václav Kubernát <kubernat@cesnet.cz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Václav Kubernát <kubernat@ceesnet.cz>
Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Link: https://lore.kernel.org/r/20210526154022.3223012-3-linux@roeck-us.net
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Documentation/hwmon/max31790.rst
drivers/hwmon/max31790.c