]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
cfg80211: Validate frequencies nested in NL80211_ATTR_SCAN_FREQUENCIES
authorSrinivas Dasari <dasaris@qti.qualcomm.com>
Thu, 6 Jul 2017 22:43:42 +0000 (01:43 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 7 Jul 2017 09:24:31 +0000 (11:24 +0200)
commitd7f13f7450369281a5d0ea463cc69890a15923ae
tree6dc8749c061563fb004e70f65bb3cb179ac18e9e
parent8feb69c7bd89513be80eb19198d48f154b254021
cfg80211: Validate frequencies nested in NL80211_ATTR_SCAN_FREQUENCIES

validate_scan_freqs() retrieves frequencies from attributes
nested in the attribute NL80211_ATTR_SCAN_FREQUENCIES with
nla_get_u32(), which reads 4 bytes from each attribute
without validating the size of data received. Attributes
nested in NL80211_ATTR_SCAN_FREQUENCIES don't have an nla policy.

Validate size of each attribute before parsing to avoid potential buffer
overread.

Fixes: 2a519311926 ("cfg80211/nl80211: scanning (and mac80211 update to use it)")
Cc: stable@vger.kernel.org
Signed-off-by: Srinivas Dasari <dasaris@qti.qualcomm.com>
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/nl80211.c