]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/bridge/sii8620: fix potential buffer overflow
authorMaciej Purski <m.purski@samsung.com>
Wed, 22 Nov 2017 09:08:38 +0000 (10:08 +0100)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:42:28 +0000 (19:42 -0600)
commitd7f4a3578a6f21dee13a072c83c03634fd925dd9
tree903a6f977dfdae337e3dda82ec437103fe7cc97d
parent38aebeee8feba93367e7fcdb06b8a85c0739f16d
drm/bridge/sii8620: fix potential buffer overflow

BugLink: https://bugs.launchpad.net/bugs/1835845
[ Upstream commit 9378cecb1ce5d618b8aff4d65113ddcf72fc1011 ]

Buffer overflow error should not occur, as mode_fixup() callback
filters pixel clock value and it should never exceed 600000. However,
current implementation is not obviously safe and relies on
implementation of mode_fixup().

Make 'i' variable never reach unsafe value in order to avoid buffer
overflow error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: bf1722ca ("drm/bridge/sii8620: rewrite hdmi start sequence")
Signed-off-by: Maciej Purski <m.purski@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1511341718-6974-1-git-send-email-m.purski@samsung.com
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/bridge/sil-sii8620.c