]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
iommu/omap: Fix -Woverflow warnings when compiling on 64-bit architectures
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 3 Mar 2020 20:27:50 +0000 (21:27 +0100)
committerJoerg Roedel <jroedel@suse.de>
Wed, 4 Mar 2020 15:24:46 +0000 (16:24 +0100)
commitd84edddc447df2d87e6ce9fbf94d95225504ab32
tree226d69f5d872e9c1c40c94f8a61533a2c4473ab3
parent6135a891dc0bc43265cd583614419e04f3fd42b4
iommu/omap: Fix -Woverflow warnings when compiling on 64-bit architectures

Although the OMAP IOMMU driver supports only ARMv7 (32-bit) platforms,
it can be compile tested for other architectures, including 64-bit ones.
In such case the warning appears:

       In file included from drivers/iommu/omap-iommu.c:33:0:
       drivers/iommu/omap-iommu.c: In function 'omap_iommu_iova_to_phys':
    >> drivers/iommu/omap-iopgtable.h:44:21: warning: large integer implicitly truncated to unsigned type [-Woverflow]
        #define IOPTE_MASK  (~(IOPTE_SIZE - 1))
                            ^
    >> drivers/iommu/omap-iommu.c:1641:41: note: in expansion of macro 'IOPTE_MASK'
           ret = omap_iommu_translate(*pte, da, IOPTE_MASK);
                                                ^~~~~~~~~~

Fix this by using architecture-depending types in omap_iommu_translate():
1. Pointer should be cast to unsigned long,
2. Virtual addresses should be cast to dma_addr_t.

On 32-bit this will be the same as original code (using u32).  On 64-bit
it should produce meaningful result, although it does not really matter.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/omap-iopgtable.h