]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ALSA: pcm: oss: Fix negative period/buffer sizes
authorTakashi Iwai <tiwai@suse.de>
Wed, 1 Dec 2021 07:36:04 +0000 (08:36 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 3 Feb 2022 17:57:50 +0000 (18:57 +0100)
commitd8b8d07fcee07bd85a11073ec0e296611e5a988d
tree7888ecde02e42d00198360ebc414c4a15211d522
parent875ec9aa9ca83000efabe16908d548496b55ccd4
ALSA: pcm: oss: Fix negative period/buffer sizes

BugLink: https://bugs.launchpad.net/bugs/1957007
commit 9d2479c960875ca1239bcb899f386970c13d9cfe upstream.

The period size calculation in OSS layer may receive a negative value
as an error, but the code there assumes only the positive values and
handle them with size_t.  Due to that, a too big value may be passed
to the lower layers.

This patch changes the code to handle with ssize_t and adds the proper
error checks appropriately.

Reported-by: syzbot+bb348e9f9a954d42746f@syzkaller.appspotmail.com
Reported-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1638270978-42412-1-git-send-email-cuibixuan@linux.alibaba.com
Link: https://lore.kernel.org/r/20211201073606.11660-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/core/oss/pcm_oss.c