]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
bnx2x: remove ndo_poll_controller
authorEric Dumazet <edumazet@google.com>
Fri, 21 Sep 2018 22:27:49 +0000 (15:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Sep 2018 04:55:25 +0000 (21:55 -0700)
commitd8ea6a91ad70ae0881d76446df27d3f58fd478c3
tree4422143129b94ef2f9a8e4aa5763002903e3663c
parent9c29bcd189f4ab1644b7125713602532d0aefdb7
bnx2x: remove ndo_poll_controller

As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.

bnx2x uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Ariel Elior <ariel.elior@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c