]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
can: etas_es58x: es58x_rx_err_msg(): fix memory leak in error path
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Tue, 26 Oct 2021 18:07:40 +0000 (03:07 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 6 Nov 2021 16:29:40 +0000 (17:29 +0100)
commitd9447f768bc8c60623e4bb3ce65b8f4654d33a50
tree662f2f70c648318cf84a929b7d38dbcdd61d28b2
parent164051a6ab5445bd97f719f50b16db8b32174269
can: etas_es58x: es58x_rx_err_msg(): fix memory leak in error path

In es58x_rx_err_msg(), if can->do_set_mode() fails, the function
directly returns without calling netif_rx(skb). This means that the
skb previously allocated by alloc_can_err_skb() is not freed. In other
terms, this is a memory leak.

This patch simply removes the return statement in the error branch and
let the function continue.

Issue was found with GCC -fanalyzer, please follow the link below for
details.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Link: https://lore.kernel.org/all/20211026180740.1953265-1-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/etas_es58x/es58x_core.c