]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
thunderbolt: Do not fail adding switch if some port is not implemented
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 4 Jul 2018 05:50:01 +0000 (08:50 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 26 Aug 2019 09:14:51 +0000 (12:14 +0300)
commitd94dcbb10183f3b384c84e65724d2b753aa53c4d
tree5d93064ba5d7a91659a71e7d022033026620fb0b
parent943795219d3cb9f8ce6ce51cad3ffe1f61e95c6b
thunderbolt: Do not fail adding switch if some port is not implemented

There are two ways to mark a port as unimplemented. Typical way is to
return port type as TB_TYPE_INACTIVE when its config space is read.
Alternatively if the port is not physically present (such as ports 10
and 11 in ICL) reading from port config space returns
TB_CFG_ERROR_INVALID_CONFIG_SPACE instead. Currently the driver bails
out from adding the switch if it receives any error during port
inititialization which is wrong.

Handle this properly and just leave the port as TB_TYPE_INACTIVE before
continuing to the next port.

This also allows us to get rid of special casing for Light Ridge port 5
in eeprom.c.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com>
Tested-by: Mario Limonciello <mario.limonciello@dell.com>
drivers/thunderbolt/ctl.c
drivers/thunderbolt/eeprom.c
drivers/thunderbolt/switch.c