]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
[media] xc5000: Don't spin waiting for analog lock
authorDevin Heitmueller <dheitmueller@kernellabs.com>
Wed, 19 Apr 2017 23:13:52 +0000 (20:13 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 10:51:05 +0000 (07:51 -0300)
commitd9928a115ac5b1b0e77f42a13b47a2a0d46d96d3
tree03e729c01fd3dbb605794b714aac17d983dd6131
parentb01052ab0924f07a80538974806f9681d8ea74d1
[media] xc5000: Don't spin waiting for analog lock

The xc5000 driver should not be spinning waiting for an analog lock.
The ioctl() should be returning immediately and the application is
responsible for polling for lock status.

This behavior isn't very visible in cases where you tune to a valid
channel, since lock is usually achieved much faster than 400ms.
However it is highly visible where doing things like changing video
standards, which sends tuning request for a frequency that is
almost never going to have an actual channel on it.

Also fixup the return values to treat zero as success and an actual
error code on error (to be consistent with other functions).  Note
this change has no practical effect at this time as none of the
callers inspect the return value.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/tuners/xc5000.c