]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/omap: fix dma_addr refcounting
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 14 Nov 2019 08:03:43 +0000 (10:03 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 4 Dec 2019 17:11:28 +0000 (19:11 +0200)
commitd9c148cfaf0a99296ad7c92fb8b65952196053ec
tree16c52ad673b2b2c92e08ada351c5d2ea79794e76
parentd6d07ca19c045924f2b9cac14cb277cc34f85d43
drm/omap: fix dma_addr refcounting

cec4fa7511ef7a73eb635834e9d85b25a5b47a98 ("drm/omap: use refcount API to
track the number of users of dma_addr") changed omap_gem.c to use
refcounting API to track dma_addr uses.  However, the driver only tracks
the refcounts for non-contiguous buffers, and the patch didn't fully
take this in account.

After the patch, the driver always decreased refcount in omap_gem_unpin,
instead of decreasing the refcount only for non-contiguous buffers. This
leads to refcounting mismatch.

As for the contiguous cases the refcount is never increased, fix this
issue by returning from omap_gem_unpin if the buffer being unpinned is
contiguous.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191114080343.30704-1-tomi.valkeinen@ti.com
Fixes: cec4fa7511ef ("drm/omap: use refcount API to track the number of users of dma_addr")
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/gpu/drm/omapdrm/omap_gem.c