]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ARM: EXYNOS: Properly skip unitialized parent clock in power domain on
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 22 Apr 2016 07:26:52 +0000 (09:26 +0200)
committerKamal Mostafa <kamal@canonical.com>
Mon, 16 May 2016 17:28:00 +0000 (10:28 -0700)
commitda3cc3593d5602bc7146a526c97f799d9b4c2405
tree39530d746e3b6541b9b189fd7ef0166474fdcec2
parent4b1783d21a03349fa653dcb082a502395948ee04
ARM: EXYNOS: Properly skip unitialized parent clock in power domain on

BugLink: http://bugs.launchpad.net/bugs/1580754
commit a0a966b83873f33778710a4fc59240244b0734a5 upstream.

We want to skip reparenting a clock on turning on power domain, if we
do not have the parent yet. The parent is obtained when turning the
domain off. However due to a typo, the loop is continued on IS_ERR() of
clock being reparented, not on the IS_ERR() of the parent.

Theoretically this could lead to OOPS on first turn on of a power
domain, if there was no turn off before. Practically that should never
happen because all power domains are turned on by default (reset value,
bootloader does not turn off them usually) so the first action will be
always turn off.

Fixes: 29e5eea06bc1 ("ARM: EXYNOS: Get current parent clock for power domain on/off")
Reported-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
arch/arm/mach-exynos/pm_domains.c