]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
x86, microcode: Return error from driver init code when loader is disabled
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Wed, 28 Jan 2015 02:21:09 +0000 (21:21 -0500)
committerBorislav Petkov <bp@suse.de>
Wed, 28 Jan 2015 08:23:40 +0000 (09:23 +0100)
commitda63865a01c6384d459464e5165d95d4f04878d8
treeb7e91fe44040729f43902db392b0f3706d8f2912
parent26bc420b59a38e4e6685a73345a0def461136dce
x86, microcode: Return error from driver init code when loader is disabled

Commits 65cef1311d5d ("x86, microcode: Add a disable chicken bit") and
a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on
paravirt") allow microcode driver skip initialization when microcode
loading is not permitted.

However, they don't prevent the driver from being loaded since the
init code returns 0. If at some point later the driver gets unloaded
this will result in an oops while trying to deregister the (never
registered) device.

To avoid this, make init code return an error on paravirt or when
microcode loading is disabled. The driver will then never be loaded.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: http://lkml.kernel.org/r/1422411669-25147-1-git-send-email-boris.ostrovsky@oracle.com
Reported-by: James Digwall <james@dingwall.me.uk>
Cc: stable@vger.kernel.org # 3.18
Signed-off-by: Borislav Petkov <bp@suse.de>
arch/x86/kernel/cpu/microcode/core.c