]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
Revert "powerpc/eeh: Fix crash in eeh_add_device_early() on Cell"
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Tue, 5 Jul 2016 19:57:44 +0000 (13:57 -0600)
committerKamal Mostafa <kamal@canonical.com>
Wed, 13 Jul 2016 15:59:26 +0000 (08:59 -0700)
commitdaa976ecd0ddf13c04513187639416f885299b80
tree9c6cd8d684f24c9adbaeba1654c1a371569eec70
parenta446218a95a419b28b93bcfe277a041c0977c540
Revert "powerpc/eeh: Fix crash in eeh_add_device_early() on Cell"

BugLink: http://bugs.launchpad.net/bugs/1599250
This reverts commit 89a51df5ab1d38b257300b8ac940bbac3bb0eb9b.

The function eeh_add_device_early() is used to perform EEH
initialization in devices added later on the system, like in
hotplug/DLPAR scenarios. Since the commit 89a51df5ab1d ("powerpc/eeh:
Fix crash in eeh_add_device_early() on Cell") a new check was introduced
in this function - Cell has no EEH capabilities which led to kernel oops
if hotplug was performed, so checking for eeh_enabled() was introduced
to avoid the issue.

However, in architectures that EEH is present like pSeries or PowerNV,
we might reach a case in which no PCI devices are present on boot time
and so EEH is not initialized. Then, if a device is added via DLPAR for
example, eeh_add_device_early() fails because eeh_enabled() is false,
and EEH end up not being enabled at all.

This reverts the aforementioned patch since a new verification was
introduced by the commit d91dafc02f42 ("powerpc/eeh: Delay probing EEH
device during hotplug") and so the original Cell issue does not happen
anymore.

Cc: stable@vger.kernel.org # v4.1+
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
(cherry picked from commit c2078d9ef600bdbe568c89e5ddc2c6f15b7982c8)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
arch/powerpc/kernel/eeh.c