]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
SMB: Validate negotiate (to protect against downgrade) even if signing off
authorSteve French <smfrench@gmail.com>
Thu, 21 Sep 2017 00:57:18 +0000 (19:57 -0500)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 12 Oct 2017 21:20:30 +0000 (16:20 -0500)
commitdaaeb28bfd42c545f907b5716c3262624261f7d3
treeb158ae2df17badeca37792a6f04009fb3ec24afb
parentf178608c1fba4461f1c4469fd0e2a47ff2576346
SMB: Validate negotiate (to protect against downgrade) even if signing off

BugLink: http://bugs.launchpad.net/bugs/1721777
commit 0603c96f3af50e2f9299fa410c224ab1d465e0f9 upstream.

As long as signing is supported (ie not a guest user connection) and
connection is SMB3 or SMB3.02, then validate negotiate (protect
against man in the middle downgrade attacks).  We had been doing this
only when signing was required, not when signing was just enabled,
but this more closely matches recommended SMB3 behavior and is
better security.  Suggested by Metze.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Acked-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
fs/cifs/smb2pdu.c