]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Revert "binder_alloc: add missing mmap_lock calls when using the VMA"
authorCarlos Llamas <cmllamas@google.com>
Tue, 2 May 2023 20:12:17 +0000 (20:12 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 9 Aug 2023 09:38:10 +0000 (11:38 +0200)
commitdad81093dd0685f55c07ade6136247dbf536e451
tree1ad7b82dd8c8495ffd8537bd72e885971504aa15
parenta67753e97d6ec13b96c37c74571530b3bc4dc871
Revert "binder_alloc: add missing mmap_lock calls when using the VMA"

BugLink: https://bugs.launchpad.net/bugs/2028979
commit b15655b12ddca7ade09807f790bafb6fab61b50a upstream.

This reverts commit 44e602b4e52f70f04620bbbf4fe46ecb40170bde.

This caused a performance regression particularly when pages are getting
reclaimed. We don't need to acquire the mmap_lock to determine when the
binder buffer has been fully initialized. A subsequent patch will bring
back the lockless approach for this.

[cmllamas: resolved trivial conflicts with renaming of alloc->mm]

Fixes: 44e602b4e52f ("binder_alloc: add missing mmap_lock calls when using the VMA")
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Carlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20230502201220.1756319-1-cmllamas@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/android/binder_alloc.c