]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
powerpc/eeh: Avoid use after free in eeh_handle_special_event()
authorRussell Currey <ruscur@russell.cc>
Wed, 19 Apr 2017 07:39:26 +0000 (17:39 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 2 May 2017 12:41:43 +0000 (22:41 +1000)
commitdaeba2956f32f91f3493788ff6ee02fb1b2f02fa
tree8c87a0fdeb9e2078a24846ea41c0a242daf0c26a
parenta715626a8e904e7226915d1bc4885317ea9da141
powerpc/eeh: Avoid use after free in eeh_handle_special_event()

eeh_handle_special_event() is called when an EEH event is detected but
can't be narrowed down to a specific PE.  This function looks through
every PE to find one in an erroneous state, then calls the regular event
handler eeh_handle_normal_event() once it knows which PE has an error.

However, if eeh_handle_normal_event() found that the PE cannot possibly
be recovered, it will free it, rendering the passed PE stale.
This leads to a use after free in eeh_handle_special_event() as it attempts to
clear the "recovering" state on the PE after eeh_handle_normal_event() returns.

Thus, make sure the PE is valid when attempting to clear state in
eeh_handle_special_event().

Fixes: 8a6b1bc70dbb ("powerpc/eeh: EEH core to handle special event")
Cc: stable@vger.kernel.org # v3.11+
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Russell Currey <ruscur@russell.cc>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/eeh_driver.c