]> git.proxmox.com Git - mirror_qemu.git/commit
trace/simple: Fix unauthorized enable
authorMarkus Armbruster <armbru@redhat.com>
Wed, 27 May 2020 06:56:13 +0000 (08:56 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 24 Jun 2020 10:21:00 +0000 (11:21 +0100)
commitdb25d56c014aa1a96319c663e0a60346a223b31e
tree71eba884363be7e000b42695fb7b20058f3bf327
parentf892b494fafd39660679c1c4ef1dbe711a73df45
trace/simple: Fix unauthorized enable

st_set_trace_file() accidentally enables tracing.  It's called
unconditionally during startup, which is why QEMU built with the
simple trace backend always writes a trace file "trace-$PID".

This has been broken for quite a while.  I didn't track down the exact
commit.

Fix st_set_trace_file() to restore the state.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200527065613.25322-1-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
trace/simple.c
trace/simple.h