]> git.proxmox.com Git - mirror_qemu.git/commit
throttle: acquire the ThrottleGroup lock in bdrv_swap()
authorAlberto Garcia <berto@igalia.com>
Mon, 8 Jun 2015 16:17:45 +0000 (18:17 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 12 Jun 2015 13:00:00 +0000 (14:00 +0100)
commitdb6283385cb708b9d589e5b57e96eab4afd0269e
tree4c50c7acecd3d79c6efb6beee4a359bfdb3322f1
parent76f4afb40fa076ed23fe0ab42c7a768ddb71123f
throttle: acquire the ThrottleGroup lock in bdrv_swap()

bdrv_swap() touches the fields of a BlockDriverState that are
protected by the ThrottleGroup lock. Although those fields end up in
their original place, they are temporarily swapped in the process,
so there's a chance that an operation on a member of the same group
happening on a different thread can try to use them.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: d92dc40d7c4f1fc5cda5cbbf4ffb7a4670b79d17.1433779731.git.berto@igalia.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c
block/throttle-groups.c
include/block/throttle-groups.h